Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: alternative isValidSignature implementation #460

Closed
wants to merge 1 commit into from
Closed

feature: alternative isValidSignature implementation #460

wants to merge 1 commit into from

Conversation

heueristik
Copy link
Contributor

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task: ID

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.

@heueristik heueristik changed the base branch from develop to feature/OS-669-dao-refactoring September 4, 2023 12:14
@heueristik heueristik force-pushed the feature/alternative-isvalidsignature-impl branch from 3c3aad4 to cde6547 Compare September 4, 2023 13:37
@heueristik
Copy link
Contributor Author

We are against this solution

@heueristik heueristik closed this Sep 18, 2023
@heueristik heueristik deleted the feature/alternative-isvalidsignature-impl branch September 27, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@heueristik