Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations in shared layouts don't work in 1.0.6, while they work in 1.0.5 #604

Closed
srflp opened this issue Apr 30, 2021 · 3 comments
Closed

Comments

@srflp
Copy link

srflp commented Apr 30, 2021

It seems like 1.0.6 introduces some breaking changes, because some of strings in my app just stopped being translated.

This regression applies only to the translations that are in a shared layout (shared via _app.js).

I prepared a reproduction repo: https://github.com/srflp/next-translate-bug

How does it behave?

  • 1.0.5:
    b3a0a9f7d528f9e5ec9e2daa6a56b9a9

  • 1.0.6 (useTranslation in a shared layout stopped working):
    3e5fc69963bce682f2a277764ea16db0

@aralroca
Copy link
Owner

aralroca commented May 1, 2021

@srflp I guess is introduced by #574, can you confirm if 1.0.6-canary.2 works for you and 1.0.6-canary.3 no? I think we can revert the PR, because it also does not solve the problem it was trying to solve. Thanks!

@aralroca
Copy link
Owner

aralroca commented May 1, 2021

@srflp it should work again on 1.0.7-canary.3 👍

@aralroca aralroca closed this as completed May 1, 2021
@srflp
Copy link
Author

srflp commented May 1, 2021

Awesome, it works again, thanks! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants