Add HTTP open_timeout #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # for various operations. | ||
| # | ||
| class Client | ||
| attr_accessor :timeout, :logger | ||
| attr_accessor :open_timeout, :read_timeout, :logger |
There was a problem hiding this comment.
Can we name these as http_open_timeout and http_read_timeout to avoid ambiguity?
There was a problem hiding this comment.
No problem. Do you still need @timeout parameter?
There was a problem hiding this comment.
Yes, let's leave it there as it is used in the System class.
|
Also the CI build is failing because the newly added attributes are not mocked yet, could you please fix that as well if you get a chance? |
|
Hi! Is that good for you? |
|
Looks great! |
|
Released as |
|
Great! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the url is wrong or not responding, timeout after
open_timeout.Keep it separated from
read_timeout.