Prevent warnings due to Hash#[] call with nil items #136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
filters.keys.all? { |key| plugin[key.to_s] == filters[key] }
returns false in PluginManager#list_installed, Hash#[] would be called with some nil items like the following codeHash[ [1,2], nil, [3,4] ]
, and this triggers warnings on Ruby 2.x. This patch prevents these warnings.