Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing tree= to View.list, use_crumbs?, use_security? to improve performance on large systems #163

Merged
merged 1 commit into from
Jan 3, 2015

Conversation

stjohnjohnson
Copy link
Contributor

We have Jenkins instances in the 10s of thousands of jobs. Loading {root}/api/json can take a while.

I found three calls that are currently loading that URL, View.list, Client.use_crumbs?, and Client.use_security?.

Instead, of loading everything, you could use the ?tree= feature to load just the value you are looking for. This is related to #89.

@stjohnjohnson
Copy link
Contributor Author

@arangamani I'm not sure if I wrote the Unit tests how you would have liked. I couldn't find any unit tests in Client that really mocked calls to api_get_request in Client. Please let me know if/how you would like me to change those tests.

@arangamani
Copy link
Owner

That's perfect!

arangamani added a commit that referenced this pull request Jan 3, 2015
Passing tree= to View.list, use_crumbs?, use_security? to improve performance on large systems
@arangamani arangamani merged commit 9c83cbd into arangamani:master Jan 3, 2015
@stjohnjohnson stjohnjohnson deleted the CrumbyTree branch January 3, 2015 23:09
@stjohnjohnson
Copy link
Contributor Author

Thank you! Could you let me know when/what version I should be looking for this change?

@arangamani
Copy link
Owner

Version 1.3.0 is pushed to rubygems.org that includes this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants