Cleaning up Node calls to make only one call for the computer item #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note, I know this will conflict with #178 if that is merged first. Just let me know and I will rebase/fix in whatever order you push. |
|
Helps with #89 |
|
@arangamani would love a review of this as well :) |
|
I'll cover everything when I get home tonight 😸 |
|
I would appreciate if you could rebase this PR. |
…ey are looking for
stjohnjohnson
force-pushed
the
SimplifyNodeCalls
branch
from
381208c
to
bce5425
Compare
|
@arangamani rebased!! |
arangamani
added a commit
that referenced
this pull request
May 29, 2015
Cleaning up Node calls to make only one call for the computer item
|
Thanks for the contributions @stjohnjohnson. I'll work on making a release sometime this weekend. |
|
No problem, let me know the new version when you do release it. :) |
|
@arangamani is there a version available yet? |
|
ping :) |
|
@stjohnjohnson Oops. I've been slacking. On it now. |
|
@stjohnjohnson Done, |
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently calls to things like
is_offline?andis_idle?make two calls to/computer: one to get the complete list and then another to find the index value of the computer you're looking for.Almost all of my Jenkins instances have hundreds of computers, so this is quite expensive.
This change here makes all of these methods access JUST the computer and JUST the data you need, and only once.