Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning when passing string literal "None" as spec.tls.caSecretName #60

Closed
ObiWahn opened this issue Mar 21, 2018 · 2 comments · Fixed by #61
Closed

warning when passing string literal "None" as spec.tls.caSecretName #60

ObiWahn opened this issue Mar 21, 2018 · 2 comments · Fixed by #61
Assignees

Comments

@ObiWahn
Copy link
Contributor

ObiWahn commented Mar 21, 2018

This line in tests/scale_test.go produces the following warning:

2018-03-21T14:19:42Z |WARN| Failed to handle event
component=operator
error="invalid deployment spec. please fix the following problem with the deployment 
    spec:
        spec.tls: Name 'None' is not a valid resource name:
        spec.tls: Name 'None' is not a valid resource name"
@ObiWahn
Copy link
Contributor Author

ObiWahn commented Mar 21, 2018

It works with a lowercase "none". So we should either update the documentation or change the internals. I am a bit surprised that it is not working with uppercase "None". When we do not match then no-tls case, then the given string should be used as secret. Furthermore it prevents the cluster from starting. This is enough reason to fail with a fatal error.
The last remaining secret to me is how the test that is already for some time on master could work for @kvahed .

@ObiWahn
Copy link
Contributor Author

ObiWahn commented Mar 21, 2018

"None" does not pass here:

if resourceNameRE.MatchString(name) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants