forked from oist/optinist
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
関数とパラメーターに説明のリンク追加 #534
Open
tsuchiyama-araya
wants to merge
5
commits into
develop-main
Choose a base branch
from
feature/display-of-functionparameter-description
base: develop-main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
関数とパラメーターに説明のリンク追加 #534
tsuchiyama-araya
wants to merge
5
commits into
develop-main
from
feature/display-of-functionparameter-description
+56
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsuchiyama-araya
requested review from
emuemuJP,
itutu-tienday and
milesAraya
December 23, 2024 03:33
itutu-tienday
requested changes
Dec 23, 2024
frontend/src/components/Workspace/FlowChart/RightDrawer/index.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/Workspace/FlowChart/RightDrawer/index.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/Workspace/FlowChart/RightDrawer/AlgorithmParamForm.tsx
Outdated
Show resolved
Hide resolved
itutu-tienday
requested changes
Dec 24, 2024
frontend/src/components/Workspace/FlowChart/RightDrawer/AlgorithmParamForm.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/Workspace/FlowChart/RightDrawer/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 現時点では、指摘事項はall resolevedを確認
- なおドキュメントへのリンクURLは仮状態と思われるため、Approve は一旦保留
- ドキュメント担当者と URLを決定の上、コードへ反映してください
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
【内容】
#510
パラメーターのタイトルと関数の説明にリンクで説明に遷移させました。