Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete type validation for list output #206

Open
jaredoconnell opened this issue Sep 6, 2024 · 1 comment
Open

Incomplete type validation for list output #206

jaredoconnell opened this issue Sep 6, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jaredoconnell
Copy link
Contributor

Currently, if you have a list output, the engine appears to use the first item to get the list schema. It does not validate hard-coded non-zero entries. This results in a validation failure when the output is created.

The engine should run infer on the other list items, then compare the type to ensure they match the first item.

@jaredoconnell jaredoconnell added the bug Something isn't working label Sep 6, 2024
@webbnh
Copy link
Contributor

webbnh commented Sep 9, 2024

Also, it should be well-behaved if the list is empty (i.e., if there is nothing to use to get the list schema). Hopefully, this is basically a "fall-through" case, since, if the list is empty, there will also be nothing to which the engine needs to apply the schema which it cannot infer...but, it's worth testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants