Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow workflow-defined deployer configs to be merged with the default deployer config instead of overwriting it #216

Open
dustinblack opened this issue Oct 8, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@dustinblack
Copy link
Member

Please describe what you would like to see in this project

When defining deployer configuration details in a workflow, this currently overwrites the default deployer. This is problematic when you simply need to add additional features to a step's deployment, such as privilege or a bind mount.

Please describe your use case

A single step in a workflow needs to run with host networking and with a bind mount. The default config in this case uses podman remote. Because the workflow deployer config completely overwrites the deployer for that step, if the podman remote parameters are not also supplied in the workflow deployer config, the result is that the step deploys locally instead of via podman remote, breaking the intended behavior of the workflow.

Defining the podman remote setting statically in the workflow on the other hand will break the use case of the workflow being intentionally run locally.

@dustinblack dustinblack added the enhancement New feature or request label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant