Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Rewrite To Prevent Locking Issues #81

Open
jaredoconnell opened this issue Apr 27, 2023 · 1 comment
Open

Possible Rewrite To Prevent Locking Issues #81

jaredoconnell opened this issue Apr 27, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@jaredoconnell
Copy link
Contributor

One possible redesigned architecture is to make it so that for every dependency in the DAG, there is a channel from the dependency to the dependent node.
The advantage of this redesign is it solves a lot of the locking issues that cause bugs right now.

However, it is essential that we add more tests that test the DAG before doing this, since this has the potential to break stuff.

@jaredoconnell jaredoconnell added the enhancement New feature or request label Apr 27, 2023
@jaredoconnell
Copy link
Contributor Author

One section of code that could benefit from some changes:

For where it calls ProvideStageInput, look into unifying, and calling an intermediate object (interface an impl) to check if it needs change the state, and lock if it makes sense. This would be helpful if we add more step providers, since the current setup is prone to locking errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant