Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Issue exporting D&D Sheet on Foundry 10 and D&D 2.1.2 #64

Open
1 task done
rrlevy opened this issue Jan 19, 2023 · 8 comments
Open
1 task done

[Bug]: Issue exporting D&D Sheet on Foundry 10 and D&D 2.1.2 #64

rrlevy opened this issue Jan 19, 2023 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@rrlevy
Copy link

rrlevy commented Jan 19, 2023

Expected Behavior

Export with default dnd5e mapping to work correctly

Current Behavior

When exporting the sheet with the default dnd5e mapping, I get an error:

image

VM35092:3 Uncaught TypeError: actor.data.data.traits.weaponProf.value.map(...).concat is not a function
[Detected 1 package: pdf-sheet]
    at eval (eval at createForm (pdfsheet.js:264:4), <anonymous>:3:10512)
    at eval (eval at createForm (pdfsheet.js:264:4), <anonymous>:3:11750)
    at Pdfconfig.createForm (pdfsheet.js:264:77)
    at Pdfconfig.onFileUpload (pdfsheet.js:393:8)
    at reader.onload (pdfsheet.js:192:31)

image

If I remove the "ProficienciesLang" section from the mapping file, it works, but without the proficiencies section being mapped, of course.

Steps to Reproduce

  1. Have a character on Foundry 10 and D&D 5e version 2.1.2 with proficiencies set
  2. No modules enabled, only pdf-sheet
  3. Configure module with default dnd5e mapping
  4. Try to export the character sheet
  5. Will show error in Foundry and specific information about it as above on console

Context

There are also plenty of warnings regardin the use of deprecated variables:

image

Version

0.22.3

Foundry VTT Version

10.291

Operating System

Linux AWS

Browser / App

Chrome

Game System

dnd5e (2.1.2)

Modules Disabled

  • I can confirm that disabling all of my other modules doesn't fix this issue.
@rrlevy rrlevy added the bug Something isn't working label Jan 19, 2023
@rrlevy
Copy link
Author

rrlevy commented Jan 19, 2023

Just additional info: even if you create AN EMPTY NEW player, the export fails with the same error

@SebaSOFT
Copy link
Contributor

SebaSOFT commented Mar 1, 2023

See mi pull request #68 It should fix this

@Matt-BW
Copy link

Matt-BW commented Jun 3, 2023

Same issue for me, can't seem to fix it even with the pull request above.

@ethernetguru
Copy link

same issue with me.

@slyandsmart
Copy link

Hi,
i have the same problem with Foundry 10.303, DND5 2.3.1 and ExportSheettoPDF 0.24.0.

Hope you can help with that. I tried different mappings and pdfs.

@EvilRenegade
Copy link

This issue went away for me after updating everything to the latest version - FVTT 11.309, D&D 2.3.1 and PDF Export 0.24.0, using Mapping dnd5eV11.

@davelamorte
Copy link

davelamorte commented Dec 1, 2023

Doesn't work anymore with FVTT 11.315 D&D 2.4.0

@davelamorte
Copy link

Upon further testing, it's the field "languages".
If it has anything more than one language, the issue appears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

8 participants