Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print the full path to files when logging to file #29

Closed
bjowes opened this issue Jun 1, 2020 · 4 comments
Closed

Print the full path to files when logging to file #29

bjowes opened this issue Jun 1, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@bjowes
Copy link
Contributor

bjowes commented Jun 1, 2020

For clarify, add the full path of each file created by the plugin to the console logs.

@archfz archfz added enhancement New feature or request good first issue Good for newcomers labels Jun 1, 2020
@bjowes
Copy link
Contributor Author

bjowes commented Jun 1, 2020

I'll be happy to implement this and submit a PR

@archfz
Copy link
Owner

archfz commented Jun 2, 2020

@bjowes That would be nice. The development on this project should be simple. The test directory contains a full setup that emulates a cypress project using this cypress plugin. You can easily manually test your changes with it. Test case where you can include the expectation for this feature already exists. Don't forget to read the development section in the readme. If you have any questions feel free to ask.

@bjowes
Copy link
Contributor Author

bjowes commented Jun 2, 2020

Development itself was fairly simple, but the unit tests revealed that some refactoring was required for proper support of win32 platform. Might be interesting to add a win32 step to the CI too.

@archfz
Copy link
Owner

archfz commented Jun 16, 2020

Released in 1.4.1.

@archfz archfz closed this as completed Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants