544 no dev instances console message #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+62
to
+66
| if (!Object.keys(output).length) { | ||
| this.log('There are no active dev instances yet. Use `architect dev` to create one.'); | ||
| } else { | ||
| this.log(JSON.stringify(output, null, 2)); | ||
| } |
There was a problem hiding this comment.
I know this is already merged but we may want to change this back - if I specifically want the output format to be json, we shouldn't return non-json even if there's no results (returning {} for example would at least not break somebodys JSON.parse() equivalent or pipe-to-jq)
github-actions bot
pushed a commit
that referenced
this pull request
Sep 23, 2022
# [1.26.0-rc.12](v1.26.0-rc.11...v1.26.0-rc.12) (2022-09-23) ### Bug Fixes * **dev:list:** 544 no dev instances console message ([#720](#720)) ([136b389](136b389))
github-actions bot
pushed a commit
that referenced
this pull request
Sep 29, 2022
# [1.26.0](v1.25.1...v1.26.0) (2022-09-29) ### Bug Fixes * **analytics:** No longer report errors caused by missing software such as docker. ([51328c1](51328c1)) * **dev:list:** 544 no dev instances console message ([#720](#720)) ([136b389](136b389)) * **dev:list:** always print json format, even on empty ([#721](#721)) ([de5924f](de5924f)) * **dev:list:** Ouptut container name for the container name instead of accidentally using the image name ([#715](#715)) ([f77cccd](f77cccd)) * **dev:list:** requires docker and compose ([#708](#708)) ([61bef4a](61bef4a)) * **dev:** add another check for compose version ([f5cacae](f5cacae)) * **dev:** Add safeguard to docker info call so that if it fails we report that docker daemon isnt running ([#700](#700)) ([185eab8](185eab8)) * **dev:** Add traefik default cert via envs as opposed to volume ([#709](#709)) ([0a1b7ad](0a1b7ad)) * **dev:** Fix https to https issue ([#704](#704)) ([f2c1053](f2c1053)) * **dev:** fixing info function when no containers are running ([#702](#702)) ([d72eb06](d72eb06)) * **dev:** Improve the way we handle local environments to avoid conflicts ([38623a6](38623a6)) * **dev:** More gracefully handle situations where previous runs were unexpectedly stopped ([d32cfd5](d32cfd5)) * **examples:** Example docs updates ([#707](#707)) ([49bff5e](49bff5e)) * **exec:** Better support for non TTY terminals ([4b05615](4b05615)) * **graph:** Make graph immutable ([#693](#693)) ([6753170](6753170)) * **scale:** Do not display interpolation as an option ([#717](#717)) ([9e1ec99](9e1ec99)) ### Features * **dev:list:** Add output type to dev list ([#711](#711)) ([63b1458](63b1458)) * **dev:** Optimize by not building the same dockerfile n times. ([#703](#703)) ([9a19997](9a19997)) * **platform:** Enable agent on cli ([#684](#684)) ([122e3d0](122e3d0)) * **scale:** Scale command ([#701](#701)) ([9c7b087](9c7b087)) * **spec:** remove deprecated sidecars field ([#716](#716)) ([2335a4e](2335a4e)) * **stop:** Add the dev:stop command ([a3617e7](a3617e7))
|
🎉 This PR is included in version 1.26.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Architect dev:list displays empty column headers instead of a message similar to components or environments when none are found.
Purpose
Update dev:list to display a similar message as components or environments when no running services are found.
Changes
Add table length and json length check before printing to console. Print friendly alternative message if no services are running.
Tests
Running dev instances:
No Running dev instances:
Docs
N/A
Pictures
please see: https://gitlab.com/architect-io/architect-cli/-/issues/544