554 re-enable http/https validation #747
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes https://gitlab.com/architect-io/architect-cli/-/issues/554.
Re-enable the check for non-http/https protocols through gateway.
Changes
If ingress has subdomain, check if the protocol is either http or https. Otherwise, throw an error.
Tests
Have 2 components:
Component 1
Component 2
This will fail because the protocol
tcp
in component 1 is exposed to public through ingress. If you comment out the ingress section, then the application won't fail.