Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

554 re-enable http/https validation #747

Merged
merged 3 commits into from
Nov 7, 2022
Merged

Conversation

mtgoncalves1
Copy link
Contributor

Overview

Closes https://gitlab.com/architect-io/architect-cli/-/issues/554.
Re-enable the check for non-http/https protocols through gateway.

Changes

If ingress has subdomain, check if the protocol is either http or https. Otherwise, throw an error.

Tests

Have 2 components:
Component 1

      name: component
      dependencies:
        dependency: latest
      services:
        app:
          interfaces:
            main: 
              port: 8080
              protocol: tcp
          environment:
            API_URL: \${{ dependencies.dependency.interfaces.api.url }}
      interfaces:
        app:
          url: \${{ services.app.interfaces.main.url }}
          ingress:
            subdomain: app

Component 2

      name: dependency
      services:
        api:
          interfaces:
            api: 443
      interfaces:
        api: \${{ services.api.interfaces.api.url }}

This will fail because the protocol tcp in component 1 is exposed to public through ingress. If you comment out the ingress section, then the application won't fail.

@mtgoncalves1 mtgoncalves1 requested a review from mueschm November 2, 2022 13:38
@mtgoncalves1 mtgoncalves1 self-assigned this Nov 2, 2022
@tjhiggins tjhiggins merged commit 975e274 into rc Nov 7, 2022
@tjhiggins tjhiggins deleted the 554-re-enable-http-validation branch November 7, 2022 15:54
github-actions bot pushed a commit that referenced this pull request Nov 7, 2022
# [1.28.0-rc.3](v1.28.0-rc.2...v1.28.0-rc.3) (2022-11-07)

### Bug Fixes

* **dev:** 554 re-enable http/https validation ([#747](#747)) ([975e274](975e274))
github-actions bot pushed a commit that referenced this pull request Nov 9, 2022
# [1.28.0](v1.27.0...v1.28.0) (2022-11-09)

### Bug Fixes

* **ci:** Add CI error message in prompts ([#752](#752)) ([4ec5ff4](4ec5ff4))
* **dev:** 554 re-enable http/https validation ([#747](#747)) ([975e274](975e274))
* **login:** reset docker login on token refresh ([85fdde6](85fdde6))
* **tasks:** 559 fix tasks ([#748](#748)) ([8c67adc](8c67adc))

### Features

* **deploy:** Init volumes ([#735](#735)) ([711abe7](711abe7))
* **register:** Warn users if they are missing dependencies ([4767fe0](4767fe0))
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

🎉 This PR is included in version 1.28.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants