Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps.ts #4

Open
hicksy opened this issue May 31, 2021 · 0 comments
Open

deps.ts #4

hicksy opened this issue May 31, 2021 · 0 comments

Comments

@hicksy
Copy link
Collaborator

hicksy commented May 31, 2021

A few commits back I was using a project-wide src/deps.ts file to export all of the dependencies used throughout the lib.

This proved to be really slow, because back then we could only import specific parts of the function lib e.g import httpAsync from 'https://raw.githubusercontent.com/architect/functions-deno/main/src/http/async/index.js', yet we'd import all the deps for the project. So I went for a 'module' specific deps.ts approach instead.

Now that the export signature has been fixed, and the whole lib can be imported like import arc from 'https://raw.githubusercontent.com/architect/functions-deno/main/src/index.js', and when caching is supported within hydrate, I think we should revert back to a single src/deps.ts file for easier maintenance / updating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant