Merge pull request #19 from codacy/fix-invalid-index-exception

machadoit · machadoit · commit d5051883a818 · 2016-01-07T11:26:40.000Z
Fix invalid index exception
diff --git a/src/Codacy/Coverage/Util/CodacyApiClient.php b/src/Codacy/Coverage/Util/CodacyApiClient.php
@@ -55,6 +55,11 @@ public function sendCoverage($commit, $data)
         curl_close($curl);
 
         $json = json_decode($json_response, true);
-        return $json['success'];
+
+        if (isset($json['success']) || array_key_exists('success', $json)) {
+            return $json['success'];
+        } else {
+            return $json['error'];
+        }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -55,6 +55,11 @@ public function sendCoverage($commit, $data)`
`55`	`55`	`curl_close($curl);`
`56`	`56`
`57`	`57`	`$json = json_decode($json_response, true);`
`58`		`- return $json['success'];`
	`58`	`+`
	`59`	`+ if (isset($json['success']) \|\| array_key_exists('success', $json)) {`
	`60`	`+ return $json['success'];`
	`61`	`+ } else {`
	`62`	`+ return $json['error'];`
	`63`	`+ }`
`59`	`64`	`}`
`60`	`65`	`}`