Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use utils-merge instead of lodash.defaults #10

Closed
andrewrk opened this issue Jun 28, 2014 · 5 comments
Closed

use utils-merge instead of lodash.defaults #10

andrewrk opened this issue Jun 28, 2014 · 5 comments

Comments

@andrewrk
Copy link
Contributor

Hi, another packaging request here. Sorry I keep doing this to you. Here's the deal:

zip-stream depends on lodash.defaults which means to create a Debian package for zip-stream, I have to package up all of these things:

│  │  ├─ lodash.defaults (~2.4.1)                 None
│  │  │  ├─ lodash.keys (~2.4.1)                  None
│  │  │  │  ├─ lodash.isobject (~2.4.1)           None
│  │  │  │  │  └─ lodash._objecttypes (~2.4.1)    None
│  │  │  │  ├─ lodash._shimkeys (~2.4.1)          None
│  │  │  │  │  └─ lodash._objecttypes (~2.4.1)    None
│  │  │  │  └─ lodash._isnative (~2.4.1)          None
│  │  │  └─ lodash._objecttypes (~2.4.1)          None

I looked into it, and if you used utils-merge instead, it would work the same way, and utils-merge is already packaged up for Debian, so it would require no work on my part.

What do you think?

@andrewrk andrewrk changed the title consider using underscore instead of lodash.defaults avoid depending on lodash.defaults Jun 28, 2014
@andrewrk andrewrk changed the title avoid depending on lodash.defaults use utils-merge instead of lodash.defaults Jun 28, 2014
@ctalkington
Copy link
Member

im trying to understand this "packaged for debian" stuff. can you elaborate?

@andrewrk
Copy link
Contributor Author

andrewrk commented Jul 1, 2014

Sure. I have to manually create a package for each and every dependency and then (the hard part) I have to get them approved and uploaded by a Debian developer. So when there are 8 dependencies (with only a tiny bit of code in each one) that makes it rather difficult, especially when there is already another package which does the job.

Another argument is that your README says "Dependencies are kept to a minimum..." so this pull request helps make that claim more true.

@ctalkington
Copy link
Member

thats regarding using node built-ins. theres no built in extend. that said i could switch to node-lodash vs the deep dep trees some of the individuals have.

@andrewrk
Copy link
Contributor Author

andrewrk commented Jul 1, 2014

That would be an equally amicable solution to me.

@andrewrk
Copy link
Contributor Author

andrewrk commented Jul 1, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants