remove pku from feature list for zen3 #40
Conversation
There was a problem hiding this comment.
As I said I think this is the wrong approach (as in the compiler can emit code that will cause illegal instruction for a detected architecture).
Looking at the discussion, there might be a "dimension" we didn't account for, i.e. compilers adding instruction sets over time to already existing architectures - I need to check that with GCC and go back to old compilers to see if not having PKU on Intel is due to that or to us forgetting adding the instruction set.
If the same microarchitecture can get new features over time we need to think how to model "optional features" and use them to emit the correct compiler flags.
@tgamblin @becker33 You might be interested in this discussion
|
Fwiw I suggested a stop-gap solution in #38 (comment) and tried to add an agenda item in the weekly telco of the Spack community https://github.com/spack/spack/wiki/Telcon:-2022-01-26 |
|
We recently merged this one in Would this be enough to consider the issue closed? |
fixes #38