Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support string durations via the SDK #190

Closed
blaine-arcjet opened this issue Feb 6, 2024 · 0 comments · Fixed by #192
Closed

Support string durations via the SDK #190

blaine-arcjet opened this issue Feb 6, 2024 · 0 comments · Fixed by #192
Assignees
@blaine-arcjet

Comments

@blaine-arcjet
Copy link
Contributor

Our protocol uses u32 representing seconds, but we want to support strings like 1d in the SDK. We should implement a similar parser as Go stdlib provides and accept number or string to our primitives.

Originally posted by @blaine-arcjet in #184 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blaine-arcjet blaine-arcjet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Support duration strings or integers on rate limit configuration arcjet/arcjet-js
1 participant
@blaine-arcjet