Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(next): Avoid appending ? if querystring is empty #71

Merged
merged 2 commits into from
Dec 15, 2023
Merged

fix(next): Avoid appending ? if querystring is empty #71

merged 2 commits into from
Dec 15, 2023

Conversation

blaine-arcjet
Copy link
Contributor

Fixes #69

This checks to see if there is a querystring before appending a ? so we don't have a dangling one in the path.

davidmytton
davidmytton approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@davidmytton davidmytton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a middleware that triggers only on the root page to see this working.

@blaine-arcjet blaine-arcjet merged commit 16ca958 into main Dec 15, 2023
7 checks passed
@blaine-arcjet blaine-arcjet deleted the phated/query-string branch December 15, 2023 15:44
@blaine-arcjet blaine-arcjet mentioned this pull request Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmytton davidmytton davidmytton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Appending a ? even when no query string
2 participants
@blaine-arcjet @davidmytton