Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove production check around baseUrl allowlist before 1.0.0 #90

Open
blaine-arcjet opened this issue Dec 22, 2023 · 2 comments
Open

Comments

@blaine-arcjet
Copy link
Contributor

In #83, we added an allowlist check for the ARCJET_BASE_URL environment variable; however, validation is only done in when process.env["NODE_ENV"] === "production" to allow for experimentation in non-production environments.

Before we hit 1.0.0, we want to remove this conditional. Users will still be able to use baseUrls not on the allowlist via custom clients.

@blaine-arcjet blaine-arcjet changed the title Remove production check around baseUrl allowlist Remove production check around baseUrl allowlist before 1.0.0 May 17, 2024
@blaine-arcjet
Copy link
Contributor Author

@davidmytton with my comment at #932 (comment), do you want to delay this further or do it before beta?

@davidmytton
Copy link
Contributor

Let's do it before 1.0.0 and delay it for beta. Using the env var is easier for us :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants