Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support for our correlation, authentication, exception handling... in Azure Functions with invocation filters #187

Closed
stijnmoreels opened this issue Dec 8, 2020 · 2 comments
Labels
area:openapi All issues related to OpenAPI specifications enhancement New feature or request feature-suggestion All issues related suggestion of a new feature. These are nice to haves but not customer requests

Comments

@stijnmoreels
Copy link
Member

Is your feature request related to a problem? Please describe.
With the HTTP correlation, we have chosen to extract the functionality in a service so it can be used inside the Azure Functions environment. This is a good (temp) solution, but we can do better.

Describe the solution you'd like
While it's still in preview, we should consider using the FunctionInvocationFilterAttribute which will allow us to run functionality just like in middleware components when the function is triggered.

Describe alternatives you've considered
Extensions on the HttpRequest, base classes, additional services so we can use other functionality of the web API library.

Additional context
Azure/azure-webjobs-sdk#1284

@stijnmoreels stijnmoreels added enhancement New feature or request feature-suggestion All issues related suggestion of a new feature. These are nice to haves but not customer requests area:openapi All issues related to OpenAPI specifications labels Dec 8, 2020
@stijnmoreels
Copy link
Member Author

We will be able to use the regular Azure Functions middleware for this, but some critical features are missing. (Like extracting the HTTP data from an FunctionContext.)
See: Azure/azure-functions-dotnet-worker#414

@stijnmoreels
Copy link
Member Author

Implementing an IFunctionsWorkerMiddleware will be a better approach, closing this in favor of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:openapi All issues related to OpenAPI specifications enhancement New feature or request feature-suggestion All issues related suggestion of a new feature. These are nice to haves but not customer requests
Projects
None yet
Development

No branches or pull requests

1 participant