Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming Enhacement in Web Project. #720

Closed
Zaigham-Gulzar opened this issue Mar 21, 2024 · 3 comments
Closed

Renaming Enhacement in Web Project. #720

Zaigham-Gulzar opened this issue Mar 21, 2024 · 3 comments

Comments

@Zaigham-Gulzar
Copy link
Contributor

Hi,
Under Web Project in Contributors/GetById
Suggested renaming is:
GetById.GetProjectByIdRequest to GetById.GetContributorByIdRequest

I found the class file name to be inconsistent with what it actually is doing inside.
@ardalis
Copy link
Owner

ardalis commented Mar 21, 2024

Yeah good catch. Copy paste error. Send a PR?

@Zaigham-Gulzar
Copy link
Contributor Author

Sent under Zaigham-Gulzar:patch-1. Happy coding. 😊

@ardalis
Copy link
Owner

ardalis commented Mar 22, 2024

Fixed by #721

@ardalis ardalis closed this as completed Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ardalis @Zaigham-Gulzar