prometheus plugin is not working when there is only one source

[chengyak]

If I only have one source like the following

sources:
  - name: VAT_Reporting_DS
    handler:
      openapi:
        source: "{env.VAT_Reporting_DS_SCHEMA_URL}"
        baseUrl: "{env.VAT_Reporting_DS_URL}"
        operationHeaders:
          Authorization: "{context.headers['authorization']}"

plugins:
  - prometheus: 
    requestCount: true
    requestSummary: true
    execute: true
    errors: true
    endpoint: /metrics

In the /metrics endpoint, it will not show any details. it always shows

 HELP graphql_mesh_fetch_duration Time spent on outgoing HTTP calls
# TYPE graphql_mesh_fetch_duration histogram

# HELP graphql_mesh_delegate_duration Time spent on delegate execution
# TYPE graphql_mesh_delegate_duration histogram

and it never updates

But if I add a second source, even it is the same definition as the followings:

sources:
  - name: VAT_Reporting_DS
    handler:
      openapi:
        source: "{env.VAT_Reporting_DS_SCHEMA_URL}"
        baseUrl: "{env.VAT_Reporting_DS_URL}"
        operationHeaders:
          Authorization: "{context.headers['authorization']}"
  - name: VAT_Reporting_DS
    handler:
      openapi:
        source: "{env.VAT_Reporting_DS_SCHEMA_URL}"
        baseUrl: "{env.VAT_Reporting_DS_URL}"
        operationHeaders:
          Authorization: "{context.headers['authorization']}"

plugins:
  - prometheus: 
    requestCount: true
    requestSummary: true
    execute: true
    errors: true
    endpoint: /metrics

All information will show in /metrics endpoint and work properly.

# HELP graphql_mesh_fetch_duration Time spent on outgoing HTTP calls
# TYPE graphql_mesh_fetch_duration histogram

# HELP graphql_mesh_delegate_duration Time spent on delegate execution
# TYPE graphql_mesh_delegate_duration histogram
graphql_mesh_delegate_duration_bucket{le="0.005",sourceName="VAT_Reporting_DS",typeName="Query",fieldName="company",args="{\"id\":116}",key="undefined"} 0
graphql_mesh_delegate_duration_bucket{le="0.01",sourceName="VAT_Reporting_DS",typeName="Query",fieldName="company",args="{\"id\":116}",key="undefined"} 0
graphql_mesh_delegate_duration_bucket{le="0.025",sourceName="VAT_Reporting_DS",typeName="Query",fieldName="company",args="{\"id\":116}",key="undefined"} 0
graphql_mesh_delegate_duration_bucket{le="0.05",sourceName="VAT_Reporting_DS",typeName="Query",fieldName="company",args="{\"id\":116}",key="undefined"} 0
graphql_mesh_delegate_duration_bucket{le="0.1",sourceName="VAT_Reporting_DS",typeName="Query",fieldName="company",args="{\"id\":116}",key="undefined"} 0
graphql_mesh_delegate_duration_bucket{le="0.25",sourceName="VAT_Reporting_DS",typeName="Query",fieldName="company",args="{\"id\":116}",key="undefined"} 0
graphql_mesh_delegate_duration_bucket{le="0.5",sourceName="VAT_Reporting_DS",typeName="Query",fieldName="company",args="{\"id\":116}",key="undefined"} 0
graphql_mesh_delegate_duration_bucket{le="1",sourceName="VAT_Reporting_DS",typeName="Query",fieldName="company",args="{\"id\":116}",key="undefined"} 0
graphql_mesh_delegate_duration_bucket{le="2.5",sourceName="VAT_Reporting_DS",typeName="Query",fieldName="company",args="{\"id\":116}",key="undefined"} 0
graphql_mesh_delegate_duration_bucket{le="5",sourceName="VAT_Reporting_DS",typeName="Query",fieldName="company",args="{\"id\":116}",key="undefined"} 0
graphql_mesh_delegate_duration_bucket{le="10",sourceName="VAT_Reporting_DS",typeName="Query",fieldName="company",args="{\"id\":116}",key="undefined"} 0
graphql_mesh_delegate_duration_bucket{le="+Inf",sourceName="VAT_Reporting_DS",typeName="Query",fieldName="company",args="{\"id\":116}",key="undefined"} 2
graphql_mesh_delegate_duration_sum{sourceName="VAT_Reporting_DS",typeName="Query",fieldName="company",args="{\"id\":116}",key="undefined"} 2954
graphql_mesh_delegate_duration_count{sourceName="VAT_Reporting_DS",typeName="Query",fieldName="company",args="{\"id\":116}",key="undefined"} 2

Is it a bug? Please advise. Thanks

[ardatan]

Please share a reproduction on CodeSandbox or StackBlitz. Thanks!

[chengyak]

@ardatan , after i fix the indentation in the github repo, I will see the following error when I start the mesh server

/graphqlmesh-debug/node_modules/prom-client/lib/registry.js:80
			throw new Error(
         ^
Error: A metric with the name graphql_envelop_phase_execute has already been registered.
    at Registry.registerMetric (/Users/graphqlmesh-debug/node_modules/prom-client/lib/registry.js:80:10)
    at new Metric (/Users/play/graphqlmesh-debug/node_modules/prom-client/lib/metric.js:48:13)
    at new Histogram (/Users/graphqlmesh-debug/node_modules/prom-client/lib/histogram.js:14:3)
    at getHistogramFromConfig (/Users/play/graphqlmesh-debug/node_modules/@graphql-mesh/plugin-prometheus/node_modules/@envelop/prometheus/cjs/utils.js:52:28)
    at Object.usePrometheus (/Users/graphqlmesh-debug/node_modules/@graphql-mesh/plugin-prometheus/node_modules/@envelop/prometheus/cjs/index.js:19:68)
    at Object.onPluginInit (/Users/graphqlmesh-debug/node_modules/@graphql-mesh/plugin-prometheus/index.js:30:34)
    at createEnvelopOrchestrator (/Users/graphqlmesh-debug/node_modules/@graphql-mesh/runtime/node_modules/@envelop/core/cjs/orchestrator.js:42:20)
    at Object.envelop (/Users/graphqlmesh-debug/node_modules/@graphql-mesh/runtime/node_modules/@envelop/core/cjs/create.js:9:72)
    at Object.getMesh (/Users/graphqlmesh-debug/node_modules/@graphql-mesh/runtime/index.js:589:31)

Replicate steps:
git clone this repo: https://github.com/chengyak/graphqlmesh-debug
after clone the code

npm install
npm run build
npm run start

Thanks.

[ardatan]

Could you update the versions to the latest?

[siladitya2]

@chengyak is this issue was resolved? I am also facing the same issue. Can you please let me know if somehow you were able to resolve this issue?

[ardatan]

delegate is done only if there are multiple sources. If there is a single source, there will be no delegation so there will be no metrics for delegation.

[jaksonlima]

Does anyone know how to fix this error?