Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request CI breaking. Error-type from master #1201

Closed
jasmo2 opened this issue Sep 17, 2019 · 2 comments
Closed

Pull request CI breaking. Error-type from master #1201

jasmo2 opened this issue Sep 17, 2019 · 2 comments

Comments

@jasmo2
Copy link

jasmo2 commented Sep 17, 2019

Hello there I am trying to send a PR to the codebase, but there are errors on the types and test that seems to be cross concerns. I would like a guide to fix. So I can effectively send the PR.

The following error are just few of them. which I haven't change at all. here is a link for the PR:
#1197

Here there are some errors when trying to execute tsc

src/generate/concatenateTypeDefs.ts:13:23 - error TS2345: Argument of type 'ITypedef' is not assignable to parameter of type 'ASTNode'.
  Type 'string' is not assignable to type 'ASTNode'.

13       typeDef = print(typeDef);
                         ~~~~~~~

src/mock.ts:149:30 - error TS2339: Property 'ofType' does not exist on type 'GraphQLType'.
  Property 'ofType' does not exist on type 'GraphQLScalarType'.

149           mockType(fieldType.ofType)(root, args, context, info),
                                 ~~~~~~

src/mock.ts:150:30 - error TS2339: Property 'ofType' does not exist on type 'GraphQLType'.
  Property 'ofType' does not exist on type 'GraphQLScalarType'.

150           mockType(fieldType.ofType)(root, args, context, info),
                                 ~~~~~~

src/mock.ts:154:39 - error TS2339: Property 'name' does not exist on type 'GraphQLType'.
  Property 'name' does not exist on type 'GraphQLList<any>'.

154         mockFunctionMap.has(fieldType.name) &&
                                          ~~~~
@yaacovCR
Copy link
Collaborator

yaacovCR commented Oct 4, 2019

This has to do with changes in latest version of graphql to typescript types, fixed in https://www.npmjs.com/package/graphql-tools-fork

@yaacovCR
Copy link
Collaborator

This stale issue has likely been fixed, tests pass on next branch and master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants