Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@graphql-tools/delegate requires TypeScript lib ESNext #6353

Open
4 tasks
AaronMoat opened this issue Jul 18, 2024 · 0 comments
Open
4 tasks

@graphql-tools/delegate requires TypeScript lib ESNext #6353

AaronMoat opened this issue Jul 18, 2024 · 0 comments

Comments

@AaronMoat
Copy link
Contributor

Issue workflow progress

Progress of the issue based on the
Contributor Workflow

  • 1. The issue provides a reproduction available on Github, Stackblitz or CodeSandbox

    Make sure to fork this template and run yarn generate in the terminal.

    Please make sure the GraphQL Tools package versions under package.json matches yours.

  • 2. A failing test has been provided
  • 3. A local solution has been provided
  • 4. A pull request is pending review

Describe the bug

I'm not sure if this counts as a bug, but after #6312, to compile the delegate library requires either of the following Typescript options:

  • "lib": ["ESNext"]
  • "skipLibCheck": true

Else the following error is emitted:

node_modules/.pnpm/@graphql-tools+delegate@10.0.13_graphql@16.9.0/node_modules/@graphql-tools/delegate/typings/leftOver.d.ts(4,37): error TS2304: Cannot find name 'PromiseWithResolvers'.

This feels less than ideal to me (relying on ESNext or skipLibCheck), but might be OK if documented.

To Reproduce Steps to reproduce the behavior:

N/A

Expected behavior

N/A

Environment:

N/A

Additional context

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant