Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version for Firefox #11

Open
lpslp opened this issue Jun 3, 2020 · 5 comments
Open

version for Firefox #11

lpslp opened this issue Jun 3, 2020 · 5 comments

Comments

@lpslp
Copy link

lpslp commented Jun 3, 2020

hi - is there a version of you great addon for Firefox?

@fffx
Copy link

fffx commented Dec 28, 2020

@lpslp This repo didn't update for many years, so I have rewritten it in React, check this https://github.com/fffx/quick-bookmark. I didn't release a firefox version for now, because I haven't decided on default key binding, as cmd+B is a firefox shortcut.

The chrome version is here https://chrome.google.com/webstore/detail/quick-bookmark/bbjekmkfbdemdbfkckbakmmiceppjkdc/related

@ardcore
Copy link
Owner

ardcore commented Jan 5, 2021

@fffx it's nice to see that you're building on top of my work, but please note that this extension was released under MIT license, according to which you're required to keep my credentials in authors fields (in, LICENSE.md, package.json, and manifest.json)

@fffx
Copy link

fffx commented Jan 6, 2021

@fffx it's nice to see that you're building on top of my work, but please note that this extension was released under MIT license, according to which you're required to keep my credentials in authors fields (in, LICENSE.md, package.json, and manifest.json)

thanks for your work, my project structure is based on web-extension-starter, and then I rewrite it by looking at your project。so the liscense is also copy from web-extension-starter。I'm sorry for not puting your notice in the lisence file. I will do it in a few days. But why I should put your liscense notice in package.json, manifest.json, since your project even don't have a package.json file? And Where do I put mutiple author in package.json or manifest.json?

@ardcore
Copy link
Owner

ardcore commented Jan 6, 2021

@fffx thanks for understanding. I think putting my name back into the LICENSE.md file and creating a separate file called AUTHORS.md listing us both (in separate lines) should be enough. :)

@fffx
Copy link

fffx commented Jan 7, 2021

FYI:
added
https://github.com/fffx/quick-bookmark/blob/master/AUTHORS.md
updated:
https://github.com/fffx/quick-bookmark/blob/master/LICENCE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants