Skip to content

Conversation

@shaun-sweet
Copy link
Contributor

Hello! I didn't see any contribution guidelines so I am just posting this in the hopes we can get this merged. This adds support for this typescript compiler option

Let me know what needs to be done to get this merged! Thanks

@ardeois ardeois self-requested a review November 17, 2023 14:06
Copy link
Owner

@ardeois ardeois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can you update the readme please?
Thanks for the contribution!

@ardeois ardeois self-assigned this Nov 17, 2023
@ardeois ardeois added the minor Increment the minor version when merged label Nov 17, 2023
@shaun-sweet
Copy link
Contributor Author

You bet

@shaun-sweet shaun-sweet requested a review from ardeois November 17, 2023 17:34
@shaun-sweet
Copy link
Contributor Author

Done! I copied the naming convention and docs from other GQL plugins as well folks can use the top level config that shares across all the plugins :) thanks for the speedy reply!

@ardeois ardeois merged commit 91471e9 into ardeois:main Nov 17, 2023
@shaun-sweet shaun-sweet deleted the feat/add-type-imports branch November 17, 2023 19:32
@hnrq
Copy link

hnrq commented Nov 24, 2023

Is there a way to keep importing enums as values instead of types?

@shaun-sweet
Copy link
Contributor Author

Is there a way to keep importing enums as values instead of types?

Yes https://the-guild.dev/graphql/codegen/plugins/typescript/typescript-mock-data#useimplementingtypes-boolean-defaultvalue-false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor Increment the minor version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants