Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify generated libc platform bindings #13

Open
ardera opened this issue Aug 8, 2022 · 0 comments
Open

Unify generated libc platform bindings #13

ardera opened this issue Aug 8, 2022 · 0 comments
Assignees
Labels
a: libc_bindings_generator Related to libc_bindings_generator a: libc_bindings Related to libc_bindings enhancement New feature or request

Comments

@ardera
Copy link
Owner

ardera commented Aug 8, 2022

now that the generated libc platform bindings are portable (i.e. the same for each ABI, so linux-armhf, arm64, i386 and amd64), the old boilerplate code that was there to wrap the platform-specific bindings and provide a common API can be deleted and we can just use the bindings that are generated for amd64 (for example).

Though we should still generate the bindings for all platforms and check whether they are the same, so for example we catch outliers such as O_NOFOLLOW and O_DIRECTORY, which have different values depending on ABI.

@ardera ardera added enhancement New feature or request a: libc_bindings Related to libc_bindings a: libc_bindings_generator Related to libc_bindings_generator labels Aug 8, 2022
@ardera ardera self-assigned this Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: libc_bindings_generator Related to libc_bindings_generator a: libc_bindings Related to libc_bindings enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant