Merge pull request #14 from CGilavert/patch-2

manchoz · web-flow · commit 7715cae8af71 · 2022-07-06T11:04:38.000+02:00
Fix wrong mask used for the Hour Alarm register
diff --git a/src/EdgeControl_RealTimeClock.cpp b/src/EdgeControl_RealTimeClock.cpp
@@ -357,7 +357,7 @@ void EdgeControl_RealTimeClockClass::setHourAlarm(uint8_t hours)
 {
     uint8_t dec = hours / 10;
     uint8_t unit = hours - (dec * 10);
-    uint8_t hour_alarm = PCF8563T_HOUR_ALARM_AE_H_MASK & ((dec << 4) + unit);
+    uint8_t hour_alarm = PCF8563T_HOUR_ALARM_ON & ((dec << 4) + unit);
     writeByte(PCF8563T_HOUR_ALARM_REG, hour_alarm); // check formula on datasheet val + 6 * (val / 10)
 }
 

Original file line number	Diff line number	Diff line change
`@@ -357,7 +357,7 @@ void EdgeControl_RealTimeClockClass::setHourAlarm(uint8_t hours)`
`357`	`357`	`{`
`358`	`358`	`uint8_t dec = hours / 10;`
`359`	`359`	`uint8_t unit = hours - (dec * 10);`
`360`		`- uint8_t hour_alarm = PCF8563T_HOUR_ALARM_AE_H_MASK & ((dec << 4) + unit);`
	`360`	`+ uint8_t hour_alarm = PCF8563T_HOUR_ALARM_ON & ((dec << 4) + unit);`
`361`	`361`	`writeByte(PCF8563T_HOUR_ALARM_REG, hour_alarm); // check formula on datasheet val + 6 * (val / 10)`
`362`	`362`	`}`
`363`	`363`