fix: notifications hang the server

Author: eigen-value

src/decoder.h

@@ -7,8 +7,6 @@
 
 using namespace RpcUtils::detail;
 
-
-
 #define MIN_RPC_BYTES   4
 
 #define MAX_BUFFER_SIZE 1024
@@ -50,7 +48,7 @@ class RpcDecoder {
     template<typename RType>
     bool get_response(const int msg_id, RType& result, RpcError& error) {
 
-        if (!packet_incoming() || packet_type()!=RESP_MSG) return false;
+        if (!packet_incoming() || _packet_type!=RESP_MSG) return false;
 
         MsgPack::Unpacker unpacker;
         unpacker.clear();
@@ -86,7 +84,7 @@ class RpcDecoder {
 
     size_t get_request(uint8_t* buffer, size_t buffer_size) {
 
-        if (packet_type() != CALL_MSG && packet_type() != NOTIFY_MSG) {
+        if (_packet_type != CALL_MSG && _packet_type != NOTIFY_MSG) {
             return 0; // No RPC
         }
 
@@ -136,6 +134,7 @@ class RpcDecoder {
 
                 _packet_type = type;
                 _packet_size = bytes_checked;
+                break;
             } else {
                 continue;
             }

src/server.h

@@ -87,22 +87,30 @@ class RPCServer {
         if (msg_type == CALL_MSG) res_packer.serialize(resp_size, RESP_MSG, msg_id);
 
         dispatcher.call(method, unpacker, res_packer);
-        reset_rpc();
 
     }
 
     bool send_response() {
-        if (res_packer.size() > 0) {
-            return decoder->send_response(res_packer);
+        if (_rpc_type == NO_MSG || res_packer.size() == 0) {
+            return true; // No response to send
+        }
+
+        if (_rpc_type == NOTIFY_MSG) {
+            reset_rpc();
+            return true;
         }
+
+        reset_rpc();
+        return decoder->send_response(res_packer);
+
     }
 
 private:
     RpcDecoder<>* decoder = nullptr;
     RpcFunctionDispatcher<MAX_CALLBACKS> dispatcher;
     uint8_t _rpc_buffer[RPC_BUFFER_SIZE];
     size_t _rpc_size = 0;
-    uint8_t _rpc_type = NO_MSG;
+    int _rpc_type = NO_MSG;
     MsgPack::Packer res_packer;
 
     void reset_rpc() {