impr: avoid creating async rpc objects when not connected

fix: connection_id must be mutexd

Author: eigen-value

src/monitor.h

@@ -136,9 +136,11 @@ class BridgeMonitor: public Stream {
 
         k_mutex_lock(&monitor_mutex, K_FOREVER);
 
+        if (!_connected) return;
+
         MsgPack::arr_t<uint8_t> message;
         RpcResult async_rpc = bridge->call(MON_READ_METHOD, size);
-        const bool ret = _connected && async_rpc.result(message);
+        const bool ret = async_rpc.result(message);
 
         if (ret) {
             for (size_t i = 0; i < message.size(); ++i) {

src/tcp_client.h

@@ -109,7 +109,9 @@ class BridgeTCPClient : public Client {
         }
 
         size_t written;
+        k_mutex_lock(&client_mutex, K_FOREVER);
         const bool ok = bridge->call(TCP_WRITE_METHOD, connection_id, payload).result(written);
+        k_mutex_unlock(&client_mutex);
         return ok? written : 0;
     }
 
@@ -185,9 +187,11 @@ class BridgeTCPClient : public Client {
 
         k_mutex_lock(&client_mutex, K_FOREVER);
 
+        if (!_connected) return;
+
         MsgPack::arr_t<uint8_t> message;
         RpcResult async_rpc = bridge->call(TCP_READ_METHOD, connection_id, size);
-        const bool ret = _connected && async_rpc.result(message);
+        const bool ret = async_rpc.result(message);
 
         if (ret) {
             for (size_t i = 0; i < message.size(); ++i) {