Select (first) target board when port is selected and has known board

Author: sandeepmistry

app/src/processing/app/Base.java

@@ -110,6 +110,8 @@ public class Base {
   //  int editorCount;
   List<Editor> editors = Collections.synchronizedList(new ArrayList<Editor>());
   Editor activeEditor;
+  
+  private static JMenu boardMenu;
 
   // these menus are shared so that the board and serial port selections
   // are the same for all windows (since the board and serial port that are
@@ -1308,6 +1310,28 @@ public void rebuildExamplesMenu(JMenu menu) {
 
   private static String priorPlatformFolder;
   private static boolean newLibraryImported;
+  
+  public void selectTargetBoard(TargetBoard targetBoard) {
+    for (int i = 0; i < boardMenu.getItemCount(); i++) {
+      JMenuItem menuItem = boardMenu.getItem(i);
+      if (!(menuItem instanceof JRadioButtonMenuItem)) {
+        continue;
+      }
+      
+      JRadioButtonMenuItem radioButtonMenuItem = ((JRadioButtonMenuItem) menuItem);
+      if (targetBoard.getName().equals(radioButtonMenuItem.getText())) {
+        radioButtonMenuItem.setSelected(true);
+        break;
+      }
+    }
+    
+    BaseNoGui.selectBoard(targetBoard);
+    filterVisibilityOfSubsequentBoardMenus(boardsCustomMenus, targetBoard, 1);
+  
+    onBoardOrPortChange();
+    rebuildImportMenu(Editor.importMenu);
+    rebuildExamplesMenu(Editor.examplesMenu);
+  }
 
   public synchronized void onBoardOrPortChange() {
     BaseNoGui.onBoardOrPortChange();
@@ -1402,7 +1426,7 @@ public void rebuildBoardsMenu() throws Exception {
     boardsCustomMenus = new LinkedList<>();
 
     // The first custom menu is the "Board" selection submenu
-    JMenu boardMenu = new JMenu(tr("Board"));
+    boardMenu = new JMenu(tr("Board"));
     boardMenu.putClientProperty("removeOnWindowDeactivation", true);
     MenuScroller.setScrollerFor(boardMenu).setTopFixedCount(1);
 

app/src/processing/app/Editor.java

@@ -95,6 +95,9 @@
 import cc.arduino.view.findreplace.FindReplace;
 import jssc.SerialPortException;
 import processing.app.debug.RunnerException;
+import processing.app.debug.TargetBoard;
+import processing.app.debug.TargetPackage;
+import processing.app.debug.TargetPlatform;
 import processing.app.forms.PasswordAuthorizationDialog;
 import processing.app.helpers.DocumentTextChangeListener;
 import processing.app.helpers.Keys;
@@ -1007,19 +1010,21 @@ private void addInternalTools(JMenu menu) {
   class SerialMenuListener implements ActionListener {
 
     private final String serialPort;
+    private final String boardId;
 
-    public SerialMenuListener(String serialPort) {
+    public SerialMenuListener(String serialPort, String boardId) {
       this.serialPort = serialPort;
+      this.boardId = boardId;
     }
 
     public void actionPerformed(ActionEvent e) {
-      selectSerialPort(serialPort);
+      selectSerialPort(serialPort, boardId);
       base.onBoardOrPortChange();
     }
 
   }
 
-  private void selectSerialPort(String name) {
+  private void selectSerialPort(String name, String boardId) {
     if(portMenu == null) {
       System.out.println(tr("serialMenu is null"));
       return;
@@ -1059,6 +1064,13 @@ private void selectSerialPort(String name) {
         // ignore
       }
     }
+    
+    if (boardId != null) {
+      TargetBoard targetBoard = BaseNoGui.getPlatform().resolveBoardById(BaseNoGui.packages, boardId);
+      if (targetBoard != null) {
+        base.selectTargetBoard(targetBoard);
+      }
+    }
 
     onBoardOrPortChange();
     base.onBoardOrPortChange();
@@ -1103,9 +1115,10 @@ public int compare(BoardPort o1, BoardPort o2) {
       }
       String address = port.getAddress();
       String label = port.getLabel();
+      String boardId = port.getBoardId();
 
       JCheckBoxMenuItem item = new JCheckBoxMenuItem(label, address.equals(selectedPort));
-      item.addActionListener(new SerialMenuListener(address));
+      item.addActionListener(new SerialMenuListener(address, boardId));
       portMenu.add(item);
     }
 
@@ -2016,7 +2029,7 @@ private boolean serialPrompt() {
      names,
      0);
     if (result == null) return false;
-    selectSerialPort(result);
+    selectSerialPort(result, null);
     base.onBoardOrPortChange();
     return true;
   }

arduino-core/src/cc/arduino/packages/BoardPort.java

@@ -36,6 +36,7 @@ public class BoardPort {
   private String address;
   private String protocol;
   private String boardName;
+  private String boardId;
   private String vid;
   private String pid;
   private String iserial;
@@ -71,6 +72,14 @@ public void setBoardName(String boardName) {
     this.boardName = boardName;
   }
 
+  public String getBoardId() {
+    return boardId;
+  }
+
+  public void setBoardId(String boardId) {
+    this.boardId = boardId;
+  }
+  
   public PreferencesMap getPrefs() {
     return prefs;
   }

arduino-core/src/cc/arduino/packages/discoverers/NetworkDiscovery.java

@@ -122,6 +122,7 @@ public void serviceResolved(ServiceEvent serviceEvent) {
 
       port.setAddress(address);
       port.setBoardName(name);
+      port.setBoardId(board);
       port.setProtocol("network");
       port.setLabel(label);
 

arduino-core/src/cc/arduino/packages/discoverers/serial/SerialBoardsLister.java

@@ -155,6 +155,7 @@ public synchronized void retriggerDiscovery(boolean polled) {
             label += " (" + boardName + ")";
           }
           boardPort.setBoardName(boardName);
+          boardPort.setBoardId(board.getId());
         }
       } else {
         if (!parts[1].equals("0000")) {

arduino-core/src/processing/app/Platform.java

@@ -269,21 +269,29 @@ public synchronized Map<String, Object> resolveDeviceByVendorIdProductId(String
     return null;
   }
 
-  public String resolveDeviceByBoardID(Map<String, TargetPackage> packages, String boardId) {
+  public TargetBoard resolveBoardById(Map<String, TargetPackage> packages, String boardId) {
     assert packages != null;
     assert boardId != null;
     for (TargetPackage targetPackage : packages.values()) {
       for (TargetPlatform targetPlatform : targetPackage.getPlatforms().values()) {
         for (TargetBoard board : targetPlatform.getBoards().values()) {
           if (boardId.equals(board.getId())) {
-            return board.getName();
+            return board;
           }
         }
       }
     }
     return null;
   }
 
+  public String resolveDeviceByBoardID(Map<String, TargetPackage> packages, String boardId) {
+    TargetBoard targetBoard = resolveBoardById(packages, boardId);
+    if (targetBoard != null) {
+      return targetBoard.getName();
+    }
+    return null;
+  }
+
   // . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . .
 
   public String getName() {