Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.2.4 Arduino Core that compiles at Arduino app compile time does not compile for M4. #1033

Open
schnoberts1 opened this issue Mar 12, 2025 · 1 comment · May be fixed by #1034
Open

4.2.4 Arduino Core that compiles at Arduino app compile time does not compile for M4. #1033

schnoberts1 opened this issue Mar 12, 2025 · 1 comment · May be fixed by #1034

Comments

@schnoberts1
Copy link

schnoberts1 commented Mar 12, 2025 •
edited
Loading

Commit 17ff057 introduces:

17ff05739 cores/arduino/mbed/connectivity/netsocket/include/netsocket/ICMPSocket.h (pennam          2025-02-04 15:29:31 +0100 40) #if MBED_CONF_LWIP_RAW_SOCKET_ENABLED
17ff05739 cores/arduino/mbed/connectivity/netsocket/include/netsocket/ICMPSocket.h (pennam          2025-02-04 15:29:31 +0100 41)     int ping(SocketAddress &socketAddress, uint32_t timeout);
17ff05739 cores/arduino/mbed/connectivity/netsocket/include/netsocket/ICMPSocket.h (pennam          2025-02-04 15:29:31 +0100 42) #endif
17ff05739 cores/arduino/mbed/connectivity/netsocket/include/netsocket/ICMPSocket.h (pennam          2025-02-04 15:29:31 +0100 43)

however in SocketHelpers.cpp:

int arduino::MbedSocketClass::ping(SocketAddress &socketAddress, uint8_t ttl, uint32_t timeout)
{
  /* ttl is not supported by mbed ICMPSocket. Default value used is 255 */
  (void)ttl;
  ICMPSocket s;
  s.set_timeout(timeout);
  s.open(getNetwork());
  int response = s.ping(socketAddress, timeout);
  s.close();

  return response;
}

the ping() call (and the ping method on MbedSocketClass) is unprotected by the MBED_CONF_LWIP_RAW_SOCKET_ENABLED macro.

Looking at the commit it's clear the new mbed is built with raw socket enabled as the macros are defined on the GIGA M7 but not the M4 aka GENERIC_STM32H747_M4 so the mbed for M4 does not compile.

I am guessing this commit was a patch on:

commit 4cd3c25bfa9e3c2152bcce5db027fe68516008d3
Author: fabik111 <fabiomassimo.centonze@gmail.com>
Date:   Wed Jan 8 16:07:55 2025 +0100

    Add ping command

which enabled raw sockets on M7 and not M4 while adding the ping command. There's no comment on the commit to explain the rationale of M7 and not M4 and no mention of a ticket so I do not feel qualified to fix it.
@schnoberts1 schnoberts1 changed the title 4.2.4 does not build 4.2.4 Arduino Core that compiles at Arduino app compile time does not compile for M4. Mar 12, 2025
@pennam pennam linked a pull request Mar 12, 2025 that will close this issue
Open
@pennam
Copy link
Contributor

pennam commented Mar 12, 2025

@schnoberts1 thanks for the heads up. #1034 should fix the build issue. The point is the M4 do not support WiFi so ping will never work.

Enabling MBED_CONF_LWIP_RAW_SOCKET_ENABLED also for M4 would be another way to fix the build issue, but also in this way ping would not work for M4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SocketHelpers: ping, fix build for generic M4 pennam/ArduinoCore-mbed
2 participants
@schnoberts1 @pennam