Skip to content

Commit 1dcfe65

Browse files
committed
github: fix verify jobs to always report status
Fix verify-core and verify-format jobs that were causing GitHub PR status checks to get stuck with "Waiting for status to be reported". Both jobs now use 'if: always()' to ensure they run and report status regardless of dependency job outcomes. Signed-off-by: iabdalkader <i.abdalkader@gmail.com>
1 parent acbf570 commit 1dcfe65

File tree

2 files changed

+30
-4
lines changed

2 files changed

+30
-4
lines changed

.github/workflows/format_check.yml

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,3 +58,20 @@ jobs:
5858
clang-format-version: '19'
5959
check-path: ${{ matrix.path['check'] }}
6060
exclude-regex: ${{ matrix.path['exclude'] }}
61+
62+
verify-format:
63+
name: verify-format
64+
runs-on: ubuntu-latest
65+
if: always()
66+
needs: format-check
67+
steps:
68+
- name: Check format results
69+
run: |
70+
if [[ "${{ needs.format-check.result }}" == "skipped" ]]; then
71+
echo "Format check was skipped"
72+
elif [[ "${{ needs.format-check.result }}" == "failure" || "${{ needs.format-check.result }}" == "cancelled" ]]; then
73+
echo "Format check failed or was cancelled"
74+
exit 1
75+
else
76+
echo "Format check completed successfully"
77+
fi

.github/workflows/package_core.yml

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ jobs:
3030
- name: Initialize Zephyr environment
3131
run: |
3232
yes | ./extra/bootstrap.sh -o=--filter=tree:0
33+
source venv/bin/activate
34+
echo "ZEPHYR_SDK_INSTALL_DIR=$(west config sdk.base-dir)" >> "$GITHUB_ENV"
3335
echo "CORE_TAG=$(git describe --tags --exact-match || git describe --always)" >> "$GITHUB_ENV"
3436
echo "CORE_ARTIFACT=ArduinoCore-zephyr-$(git describe --always)" >> "$GITHUB_ENV"
3537
echo "BOARD_VARIANTS=$(extra/get_board_details.sh | jq -cr 'sort_by(.variant)')" >> "$GITHUB_ENV"
@@ -42,6 +44,7 @@ jobs:
4244
- name: Build variants
4345
shell: bash
4446
run: |
47+
source venv/bin/activate
4548
./extra/build_all.sh -f
4649
4750
- name: Package core
@@ -184,15 +187,21 @@ jobs:
184187
failOnError: false
185188

186189
verify-core:
187-
name: Collect job errors
190+
name: verify-core
188191
runs-on: ubuntu-latest
189-
if: cancelled() || contains(needs.*.result, 'failure')
192+
if: always()
190193
needs:
191194
- package-core
192195
- test-core
193196
steps:
194-
- name: Notify failure
195-
run: exit 1
197+
- name: Check job results
198+
run: |
199+
if [[ "${{ needs.package-core.result }}" == "failure" || "${{ needs.test-core.result }}" == "failure" || "${{ needs.package-core.result }}" == "cancelled" || "${{ needs.test-core.result }}" == "cancelled" ]]; then
200+
echo "One or more required jobs failed or were cancelled"
201+
exit 1
202+
else
203+
echo "All required jobs completed successfully"
204+
fi
196205
197206
publish-core:
198207
name: Publish core

0 commit comments

Comments
 (0)