Skip to content

Commit df12786

Browse files
When launching core list with no installed platforms print no platforms installed (#2238)
1 parent 0f516bb commit df12786

File tree

2 files changed

+15
-3
lines changed

2 files changed

+15
-3
lines changed

internal/cli/core/list.go

+2-3
Original file line numberDiff line numberDiff line change
@@ -82,10 +82,9 @@ func (ir installedResult) Data() interface{} {
8282
}
8383

8484
func (ir installedResult) String() string {
85-
if ir.platforms == nil || len(ir.platforms) == 0 {
86-
return ""
85+
if len(ir.platforms) == 0 {
86+
return tr("No platforms installed.")
8787
}
88-
8988
t := table.New()
9089
t.SetHeader(tr("ID"), tr("Installed"), tr("Latest"), tr("Name"))
9190
for _, p := range ir.platforms {

internal/integrationtest/core/core_test.go

+13
Original file line numberDiff line numberDiff line change
@@ -1058,3 +1058,16 @@ func TestCoreUpgradeWarningWithPackageInstalledButNotIndexed(t *testing.T) {
10581058
requirejson.Query(t, jsonStdout, ".warnings[]", `"missing package index for test:x86, future updates cannot be guaranteed"`)
10591059
})
10601060
}
1061+
1062+
func TestCoreListWhenNoPlatformAreInstalled(t *testing.T) {
1063+
env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
1064+
defer env.CleanUp()
1065+
1066+
stdout, _, err := cli.Run("core", "list", "--format", "json")
1067+
require.NoError(t, err)
1068+
requirejson.Empty(t, stdout)
1069+
1070+
stdout, _, err = cli.Run("core", "list")
1071+
require.NoError(t, err)
1072+
require.Equal(t, "No platforms installed.\n", string(stdout))
1073+
}

0 commit comments

Comments
 (0)