Skip to content

Commit ffb3d2f

Browse files
[skip-changelog] Fix failing board tests (#2222)
* Fix failing board tests after package index updates * Remove duplicate test
1 parent 642996f commit ffb3d2f

File tree

1 file changed

+1
-25
lines changed

1 file changed

+1
-25
lines changed

internal/integrationtest/board/board_test.go

+1-25
Original file line numberDiff line numberDiff line change
@@ -124,30 +124,6 @@ func TestBoardListWithFqbnFilterInvalid(t *testing.T) {
124124
requirejson.Query(t, stderr, ".error", `"Invalid FQBN: not an FQBN: yadayada"`)
125125
}
126126

127-
func TestBoardListWithInvalidDiscovery(t *testing.T) {
128-
env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
129-
defer env.CleanUp()
130-
131-
_, _, err := cli.Run("core", "update-index")
132-
require.NoError(t, err)
133-
_, _, err = cli.Run("board", "list")
134-
require.NoError(t, err)
135-
136-
// check that the CLI does not crash if an invalid discovery is installed
137-
// (for example if the installation fails midway).
138-
// https://github.com/arduino/arduino-cli/issues/1669
139-
toolDir := cli.DataDir().Join("packages", "builtin", "tools", "serial-discovery")
140-
dirsToEmpty, err := toolDir.ReadDir()
141-
require.NoError(t, err)
142-
require.Len(t, dirsToEmpty, 1)
143-
require.NoError(t, dirsToEmpty[0].RemoveAll())
144-
require.NoError(t, dirsToEmpty[0].MkdirAll())
145-
146-
_, stderr, err := cli.Run("board", "list")
147-
require.NoError(t, err)
148-
require.Contains(t, string(stderr), "builtin:serial-discovery")
149-
}
150-
151127
func TestBoardListall(t *testing.T) {
152128
env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
153129
defer env.CleanUp()
@@ -405,7 +381,7 @@ func TestBoardSearch(t *testing.T) {
405381
// Verifies no board has FQBN set since no platform is installed
406382
requirejson.Query(t, stdout, "[ .[] | select(.fqbn) ] | length", "0")
407383
requirejson.Contains(t, stdout, `[
408-
{"name": "Arduino Uno"},
384+
{"name": "Arduino UNO"},
409385
{"name": "Arduino Yún"},
410386
{"name": "Arduino Zero"},
411387
{"name": "Arduino Nano 33 BLE"},

0 commit comments

Comments
 (0)