Skip to content

Commit e3fa9df

Browse files
committed
use the zip notarized file coming from gon, this requires changes in the installer config
1 parent acf0aaa commit e3fa9df

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

Diff for: .github/workflows/release.yml

+10-9
Original file line numberDiff line numberDiff line change
@@ -266,23 +266,20 @@ jobs:
266266
}
267267
268268
# Ask Gon for zip output to force notarization process to take place.
269-
# The CI will ignore the zip output, using the signed binary only.
269+
# The CI will upload the zip output
270270
zip {
271-
output_path = "arduino-create-agent.zip"
271+
output_path = "ArduinoCreateAgent.app_notarized.zip"
272272
}
273273
EOF
274274
275275
- name: Sign and notarize binary
276276
run: gon -log-level=debug -log-json "${{ env.GON_CONFIG_PATH }}"
277277

278-
# This step will overwrite the non signed mac artifact (arduino-create-agent-${{ env.RUNS_ON }})
279278
- name: Upload artifact
280279
uses: actions/upload-artifact@v3
281280
with:
282-
name: ${{ env.PROJECT_NAME }}-${{ matrix.os }}${{ matrix.arch }}
283-
path: |
284-
${{ env.PROJECT_NAME }}
285-
!${{ env.PROJECT_NAME }}.zip
281+
name: ArduinoCreateAgent.app_notarized
282+
path: ArduinoCreateAgent.app_notarized.zip
286283
if-no-files-found: error
287284

288285
# This job is responsible for generating the installers (using installbuilder)
@@ -314,24 +311,28 @@ jobs:
314311
- os: ubuntu-20.04
315312
install-builder-name: linux
316313
executable-path: artifacts/linux-amd64/
314+
artifact-name: arduino-create-agent-ubuntu-20.04-amd64
317315
- os: windows-2019
318316
arch: -386
319317
browser: edge
320318
install-builder-name: windows
321319
executable-path: artifacts/windows/
322320
extension: .exe
323321
installer-extension: .exe
322+
artifact-name: arduino-create-agent-windows-2019-386
324323
- os: windows-2019
325324
browser: edge
326325
install-builder-name: windows
327326
executable-path: artifacts/windows/
328327
extension: .exe
329328
installer-extension: .exe
329+
artifact-name: arduino-create-agent-windows-2019-amd64
330330
- os: macos-12
331331
browser: safari
332332
install-builder-name: osx
333-
executable-path: 'skel/ArduinoCreateAgent.app/Contents/MacOS/'
333+
executable-path: artifacts/macos/
334334
installer-extension: .app
335+
artifact-name: ArduinoCreateAgent.app_notarized
335336

336337
container:
337338
image: floydpink/ubuntu-install-builder:22.10.0
@@ -346,7 +347,7 @@ jobs:
346347
- name: Download artifact
347348
uses: actions/download-artifact@v3
348349
with:
349-
name: ${{ env.PROJECT_NAME }}-${{ matrix.os }}${{ matrix.arch }}
350+
name: ${{ matrix.artifact-name }}
350351
path: ${{ matrix.executable-path }} # path expected by installbuilder
351352

352353
# zip artifacts do not mantain executable permission

0 commit comments

Comments
 (0)