Disable autodownload of updates on startup (#860)

Author: fstasi

arduino-ide-extension/src/electron-main/arduino-electron-main-module.ts

@@ -18,7 +18,7 @@ import {
   IDEUpdaterClient,
   IDEUpdaterPath,
 } from '../common/protocol/ide-updater';
-import { IDEUpdaterImpl } from '../node/ide-updater/ide-updater-impl';
+import { IDEUpdaterImpl } from './ide-updater/ide-updater-impl';
 
 export default new ContainerModule((bind, unbind, isBound, rebind) => {
   bind(ElectronMainApplication).toSelf().inSingletonScope();

arduino-ide-extension/src/node/ide-updater/ide-updater-impl.ts renamed to arduino-ide-extension/src/electron-main/ide-updater/ide-updater-impl.ts

@@ -18,6 +18,7 @@ export class IDEUpdaterImpl implements IDEUpdater {
   protected clients: Array<IDEUpdaterClient> = [];
 
   init(channel: UpdateChannel) {
+    this.updater.autoDownload = false;
     this.updater.channel = channel;
     this.updater.setFeedURL({
       provider: 'generic',
@@ -27,35 +28,33 @@ export class IDEUpdaterImpl implements IDEUpdater {
       channel,
     });
 
-    this.updater.on('checking-for-update', (e) =>
-      this.clients.forEach((c) => c.notifyCheckingForUpdate(e))
-    );
-    this.updater.on('update-available', (e) =>
-      this.clients.forEach((c) => c.notifyUpdateAvailable(e))
-    );
-    this.updater.on('update-not-available', (e) =>
-      this.clients.forEach((c) => c.notifyUpdateNotAvailable(e))
-    );
-    this.updater.on('download-progress', (e) =>
-      this.clients.forEach((c) => c.notifyDownloadProgressChanged(e))
-    );
-    this.updater.on('update-downloaded', (e) =>
-      this.clients.forEach((c) => c.notifyDownloadFinished(e))
-    );
-    this.updater.on('error', (e) =>
-      this.clients.forEach((c) => c.notifyError(e))
-    );
+    this.updater.on('checking-for-update', (e) => {
+      this.clients.forEach((c) => c.notifyCheckingForUpdate(e));
+    });
+    this.updater.on('update-available', (e) => {
+      this.clients.forEach((c) => c.notifyUpdateAvailable(e));
+    });
+    this.updater.on('update-not-available', (e) => {
+      this.clients.forEach((c) => c.notifyUpdateNotAvailable(e));
+    });
+    this.updater.on('download-progress', (e) => {
+      this.clients.forEach((c) => c.notifyDownloadProgressChanged(e));
+    });
+    this.updater.on('update-downloaded', (e) => {
+      this.clients.forEach((c) => c.notifyDownloadFinished(e));
+    });
+    this.updater.on('error', (e) => {
+      this.clients.forEach((c) => c.notifyError(e));
+    });
   }
 
   setClient(client: IDEUpdaterClient | undefined): void {
     if (client) this.clients.push(client);
   }
 
   async checkForUpdates(): Promise<UpdateInfo | void> {
-    const {
-      updateInfo,
-      cancellationToken,
-    } = await this.updater.checkForUpdates();
+    const { updateInfo, cancellationToken } =
+      await this.updater.checkForUpdates();
 
     this.cancellationToken = cancellationToken;
     if (this.updater.currentVersion.compare(updateInfo.version) === -1) {