test: split up test cases

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>

Author: Akos Kitta

arduino-ide-extension/src/test/browser/create-api.test.ts

@@ -228,89 +228,46 @@ describe('create-api', () => {
     expect(findByName(otherName, sketches)).to.be.not.undefined;
   });
 
-  it('should not run unnecessary fetches when retrieving all sketches', async () => {
-    const content = 'void setup(){} void loop(){}';
-    const maxLimit = 50; // https://github.com/arduino/arduino-ide/pull/875
-    const sketchNames = [...Array(maxLimit - 1).keys()].map(() => v4());
-
-    // #region - sketch count < offset
-    await sketchNames
-      .map((name) => createApi.createSketch(toPosix(name), content))
-      .reduce(async (acc, curr) => {
-        await acc;
-        return curr;
-      }, Promise.resolve() as Promise<unknown>);
-
-    createApi.resetRequestRecording();
-    let sketches = await createApi.sketches();
-    let actualRecording = createApi.requestRecording.slice();
-
-    expect(sketches.length).to.be.equal(maxLimit - 1);
-    sketchNames.forEach(
-      (name) => expect(findByName(name, sketches)).to.be.not.undefined
-    );
-
-    expect(actualRecording.length).to.be.equal(1);
-    let getSketchesRequests = actualRecording.filter(
-      (description) =>
-        description.method === 'GET' &&
-        description.pathname === '/create/v2/sketches' &&
-        description.query &&
-        description.query.includes(`limit=${maxLimit}`)
-    );
-    expect(getSketchesRequests.length).to.be.equal(1);
-    // #endregion
-
-    // #region - sketch count === offset
-    let extraName = v4();
-    sketchNames.push(extraName);
-    await createApi.createSketch(toPosix(extraName), content);
-
-    createApi.resetRequestRecording();
-    sketches = await createApi.sketches();
-    actualRecording = createApi.requestRecording.slice();
-
-    expect(sketches.length).to.be.equal(maxLimit);
-    sketchNames.forEach(
-      (name) => expect(findByName(name, sketches)).to.be.not.undefined
-    );
-
-    expect(actualRecording.length).to.be.equal(2);
-    getSketchesRequests = actualRecording.filter(
-      (description) =>
-        description.method === 'GET' &&
-        description.pathname === '/create/v2/sketches' &&
-        description.query &&
-        description.query.includes(`limit=${maxLimit}`)
-    );
-    expect(getSketchesRequests.length).to.be.equal(2);
-    // #endregion
-
-    // #region - sketch count > offset
-    extraName = v4();
-    sketchNames.push(extraName);
-    await createApi.createSketch(toPosix(extraName), content);
-
-    createApi.resetRequestRecording();
-    sketches = await createApi.sketches();
-    actualRecording = createApi.requestRecording.slice();
-
-    expect(sketches.length).to.be.equal(maxLimit + 1);
-    sketchNames.forEach(
-      (name) => expect(findByName(name, sketches)).to.be.not.undefined
-    );
+  [
+    [-1, 1],
+    [0, 2],
+    [1, 2],
+  ].forEach(([diff, expected]) =>
+    it(`should not run unnecessary fetches when retrieving all sketches (sketch count ${
+      diff < 0 ? '<' : diff > 0 ? '>' : '='
+    } limit)`, async () => {
+      const content = 'void setup(){} void loop(){}';
+      const maxLimit = 50; // https://github.com/arduino/arduino-ide/pull/875
+      const sketchCount = maxLimit + diff;
+      const sketchNames = [...Array(sketchCount).keys()].map(() => v4());
+
+      await sketchNames
+        .map((name) => createApi.createSketch(toPosix(name), content))
+        .reduce(async (acc, curr) => {
+          await acc;
+          return curr;
+        }, Promise.resolve() as Promise<unknown>);
+
+      createApi.resetRequestRecording();
+      const sketches = await createApi.sketches();
+      const allRequests = createApi.requestRecording.slice();
+
+      expect(sketches.length).to.be.equal(sketchCount);
+      sketchNames.forEach(
+        (name) => expect(findByName(name, sketches)).to.be.not.undefined
+      );
 
-    expect(actualRecording.length).to.be.equal(2);
-    getSketchesRequests = actualRecording.filter(
-      (description) =>
-        description.method === 'GET' &&
-        description.pathname === '/create/v2/sketches' &&
-        description.query &&
-        description.query.includes(`limit=${maxLimit}`)
-    );
-    expect(getSketchesRequests.length).to.be.equal(2);
-    // #endregion
-  });
+      expect(allRequests.length).to.be.equal(expected);
+      const getSketchesRequests = allRequests.filter(
+        (description) =>
+          description.method === 'GET' &&
+          description.pathname === '/create/v2/sketches' &&
+          description.query &&
+          description.query.includes(`limit=${maxLimit}`)
+      );
+      expect(getSketchesRequests.length).to.be.equal(expected);
+    })
+  );
 
   ['.', '-', '_'].map((char) => {
     it(`should create a new sketch with '${char}' in the sketch folder name although it's disallowed from the Create Editor`, async () => {