Skip to content

#989 Listen on keyboard layout changes from the OS #1478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2022
Merged

#989 Listen on keyboard layout changes from the OS #1478

merged 1 commit into from
Sep 26, 2022

Conversation

@kittaakos
Copy link
Contributor

Motivation

Delegate keyboard layout changes from the OS to the IDE2 frontend.

How to test:

Change description

Other information

Closes #989

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

Listen on keyboard layout changes from the OS.
4184b05 
Closes #989

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project topic: theia Related to the Theia IDE framework labels Sep 21, 2022
@kittaakos kittaakos merged commit 707f3be into main Sep 26, 2022
@kittaakos kittaakos deleted the #989 branch September 26, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@per1234 per1234 Awaiting requested review from per1234

@francescospissu francescospissu Awaiting requested review from francescospissu

1 more reviewer

@AlbyIanna AlbyIanna AlbyIanna approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

topic: code Related to content of the project itself topic: theia Related to the Theia IDE framework type: imperfection Perceived defect in any part of project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Keyboard bindings do not work properly after change to different keyboard layouts

2 participants

@kittaakos @AlbyIanna