#573 Listen on the client's port change event

[kittaakos]

Motivation

Listen on the client's port changes to fix intermittent failure to recognize ports.

The problem was that the board select dialog was listening on the backend's board/port changes to show the available ports in the dialog. This was fundamentally incorrect as the following use case could happen.

• Attach boards,
• Start IDE2,
• Backend starts and detects the boards and ports via the board list -w gRPC equivalent, dispatches board/port change event but client is not started yet,
• Client starts,
• Initialize the dialog with zero ports (this is common practice to init with empty),
• Listen on the backend board/port changes (event never arrives),
• Attach/detach a board, and the ports section in the dialog starts working.

It was never an issue with the Tool > Port menu, as it was correctly listening on the client's events:

arduino-ide/arduino-ide-extension/src/browser/contributions/board-selection.ts

Lines 109 to 111 in bc264d1

	this.boardsServiceProvider.onAvailablePortsChanged(() =>
	this.updateMenus()
	);

With the proposed changes, the dialog is correctly listening on the client's board/port changes, so it cannot miss the event.

Change description

Other information

Closes #573

Locally, it was easy to reproduce the defect. Attach boards before starting IDE2. When IDE2 is up, open the board select dialog. Ports were empty. Now, it should work with the build from this PR.

Reviewer checklist

• PR addresses a single concern.
• The PR has no duplicates (please search among the Pull Requests before creating one)
• PR title and description are properly filled.
• Docs have been added / updated (for bug fixes / features)

[AlbyIanna]

Tested it and it works just fine. I've just left a little remark on the code, but to me it's already okay ✅

[per1234]

I am not able to reproduce the fault so I can't verify that the change proposed here fixes it.

I don't experience any problems when using the build for this PR though.