Skip to content

NOde.js problem still not solved #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
RobTillaart opened this issue Oct 7, 2024 · 2 comments
Closed
3 tasks done

NOde.js problem still not solved #414

RobTillaart opened this issue Oct 7, 2024 · 2 comments
Assignees
Labels
conclusion: invalid Issue/PR not valid topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project

Comments

@RobTillaart
Copy link

Describe the problem

See #344

To reproduce

Ran this morning an Arduino-lint

Expected behavior

NO error message or warning
now Im getting still this warning:

Annotations
1 warning

The following actions use a deprecated Node.js version and will be forced to run on node20: arduino/arduino-lint-action@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

'arduino/arduino-lint-action' version

arduino/arduino-lint-action@v4

Additional context

#344

my yml file looks like

name: Arduino-lint

on: [push, pull_request]
jobs:
  lint:
    runs-on: ubuntu-latest
    timeout-minutes: 5
    steps:
      - uses: actions/checkout@v4
      - uses: arduino/arduino-lint-action@v1
        with:
          library-manager: update
          compliance: strict

which is functional identical to the one proposed in the readme.md file.

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest version
  • My report contains all necessary details
@RobTillaart RobTillaart added the type: imperfection Perceived defect in any part of project label Oct 7, 2024
@per1234 per1234 self-assigned this Oct 7, 2024
@per1234
Copy link
Contributor

per1234 commented Oct 7, 2024

@RobTillaart in fact it is solved, but you aren't using the version of the action that has the update.

When you do this:

- uses: arduino/arduino-lint-action@v1

it causes the release version of the action to be used. There hasn't been a release of the action since Node.js was updated so it is expected that this will cause the version of the action configured for Node.js 16 to be used.

If you want to try the beta tester version of the action which is configured for Node.js, you must do this:

- uses: arduino/arduino-lint-action@main

Or you can just wait for the next release of the action to come out (which should happen later today).

@per1234 per1234 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 7, 2024
@per1234 per1234 added conclusion: invalid Issue/PR not valid topic: infrastructure Related to project infrastructure labels Oct 7, 2024
@RobTillaart
Copy link
Author

@per1234

Thanks for the explanation, I'll wait for the update.
I assume I have to configure version 2 or so?

- uses: arduino/arduino-lint-action@v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: invalid Issue/PR not valid topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

2 participants