Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightbox QA / tweaks #1961

Open
2 of 20 tasks
csherron opened this issue Apr 9, 2019 · 1 comment
Open
2 of 20 tasks

lightbox QA / tweaks #1961

csherron opened this issue Apr 9, 2019 · 1 comment

Comments

@csherron
Copy link
Contributor

csherron commented Apr 9, 2019

sidebar

  • 'blocks w/ this url appear in' should be the last ones to load when there is a 'load more' link present - currently both show up and confuse the interface (example: https://www.are.na/block/3069486)
  • on channel bar lists with the (load more) button, newly connected channels don't appear in the list after connecting
  • underline + put parenthesis on "(LOAD MORE)" link
  • visually, the 'load more' should be 20px higher
  • make 'load more' a more plain text link, not an invisible channel bar zone
  • move 'edit block' button up 20px

margins

  • consistent margins for ALL media types on both slideshow and lightbox (currently the maximum sizes for all the media types are all over the place, leading to a messy slideshow experience). make sure that there's 50px of margin on all sides for all media and that no media stretches beyond that point! this is also to protect the left/right arrows, close button, exit fullscreen button (see pics)

Screen Shot 2019-04-09 at 9 47 01 AM

Screen Shot 2019-04-09 at 9 47 07 AM

Screen Shot 2019-04-09 at 9 47 16 AM

Screen Shot 2019-04-09 at 9 46 57 AM

  • leave an additional 60px underneath for media with captions and vertically center the text within that area (see pic)

Screen Shot 2019-04-09 at 9 46 45 AM

  • full screen pdfs bleed too much atm

fullscreen / close fullscreen button

  • make 32 x 32 px (instead of 40x40)
  • make the fullscreen button's border gray.regular
  • make the bottom+right margins 26px (align with 'x')

links in lightbox

  • on links that have long urls, make the text overflow so that the url bar remains a single line high
  • make the gradient on links heaver, whatever the transparency value is double it

edit block modal

  • description text box font is too small, doesn't match the input font size in the title field
  • make edit text box 340px tall to start with (too congested near the bottom on 13" laptop)

various

  • make lightbox background opacity 98%
  • try fade animation on slideshow mode? would rather wait a few seconds for something to fade in than get all the blinkiness that still occurs
  • there's currently no hoverstate on lightbox links (source, find orig, share, mute etc)
  • Pin caption to the bottom in fullscreen mode
@dzucconi
Copy link
Member

dzucconi commented Apr 9, 2019

@csherron Let's have a call to go over this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants