Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is a fix for issue #10038 (first LED in a WS2812 string flicks c… #10088

Merged
merged 1 commit into from
Dec 8, 2020

Conversation

vic42
Copy link

@vic42 vic42 commented Dec 7, 2020

…olors instead of fading)

Description:

corrects fading code for WS2812 color schemes

Related issue (if applicable): fixes #10038

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works on Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works on Tasmota core ESP32 V.1.0.4.2
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@arendst arendst merged commit 2fcc858 into arendst:development Dec 8, 2020
@vic42 vic42 deleted the prepare_pr branch December 8, 2020 11:19
@KDMcMullan
Copy link
Contributor

You're welcome. Sometimes the stuff you read on the internet is just wrong. We are entering an evolutionary stage where "but the internet said..." and therefore it must be true. I wonder how many people have fixed this by adding in a 74LS125 as their output stage? A few of us still retain analytical ability of our own. We are dying out. You'll never see a textbook answer from me: I never read the textbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

First LED in addressable string does not fade when using scheme
3 participants