Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ezo D.O sensor #11083

Merged
merged 2 commits into from
Feb 22, 2021
Merged

Fix Ezo D.O sensor #11083

merged 2 commits into from
Feb 22, 2021

Conversation

araujo428
Copy link

Description:

  • Unit of measure of Disolved Oxygen was in ppm and should be in mg/L, added new define D_UNIT_MILIGRAMS_PER_LITER on every translation and fixed unit of measure on i18n.h
  • Sensor was not detected on ProcessDetection because of DO id
  • Code fixes on multiple ezo sensors when USE_WEBSERVER was not defined
    Related issue (if applicable): fixes #

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works on Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works on Tasmota core ESP32 V.1.0.5-rc6
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

André Araújo added 2 commits February 22, 2021 10:40
- Unit of measure was in ppm and should be in mg/L
- Sensor was not detected
- Code fixes on multiple ezo sensors
@arendst arendst merged commit a31a778 into arendst:development Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants