Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the new IP after the Wi-Fi Initial Config #12091

Merged
merged 1 commit into from
May 13, 2021

Conversation

ascillato
Copy link
Contributor

@ascillato ascillato commented May 12, 2021

Description:

Show the new IP after the Wi-Fi Initial Config.

If using the default option keys for the Initial Wi-Fi Config:

#define RESTART_AFTER_INITIAL_WIFI_CONFIG         true
#define AFTER_INITIAL_WIFI_CONFIG_GO_TO_NEW_IP    true

After configuring the Wi-Fi credentials, Tasmota tests the connection and if everything is correct, it connects to the new Wi-Fi Network and redirects the user to the new IP.
In PCs this works fine.
In Iphone/Ipad this works fine too.
In Android phones using chrome and going to 192.168.4.1, it also works fine.
But, in some Android phones, if using the captive portal, that captive portal will be closed after Tasmota shutdowns its own AP, due to successful connection to the new Network, and the redirection to the new IP is not happening (due to there isn't open any browser anymore). So, for this case, this PR shows the new IP address in the last screen that the users will see before their phones close the browser.

BEFORE:
image

AFTER:
image

The IP it is also an Hyperlink to the new IP.

Related issue (if applicable): NA

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works on Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with core ESP32 V.1.0.6
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@ascillato ascillato changed the title Show the new IP in the Wi-Fi Initial Config Show the new IP after the Wi-Fi Initial Config May 12, 2021
@arendst arendst merged commit 9742a4e into arendst:development May 13, 2021
@ascillato ascillato deleted the patch-1 branch May 13, 2021 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants