Feature/can bus #12651
Merged
Feature/can bus #12651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tProjects into feature/can-bus
…tProjects into feature/can-bus
arendst
reviewed
Jul 14, 2021
arendst
reviewed
Jul 14, 2021
arendst
reviewed
Jul 16, 2021
| #define MCP2515_BMS_FREEDWON | ||
| #endif // MCP2515_BMS_FREEDWON | ||
| #endif // MCP2515_BMS_CLIENT | ||
|
|
There was a problem hiding this comment.
Nice set of defines.
If the user does not define the BMS client it is defined anyway. On the other hand I understand that without any client the current implementation is of no use either.
|
@mbezuidenhout Seems like this driver is pretty specific to the Freedom Won BMS? What would it take to expand it to a general purpose MCP2515 Canbus bridge/driver? Just diving into Canbus, specifically the VW e-Golf battery implementation, where @Tom-evnut has done some good work already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added support for MCP2515 CAN controller.
Reading and reporting of Freedom Won Lite battery (RJ45 pins 7 & 8) State of Charge on CAN bus.
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass