Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BL0942 to xnrg_14_bl09xx.ino #13259

Merged
merged 1 commit into from
Oct 3, 2021

Conversation

barbudor
Copy link
Contributor

@barbudor barbudor commented Oct 2, 2021

Description:

Following #13190

Added support for BL0942 to `xnrg_14_bl09xx.ino"
Similar serial protocol but 23 bytes instead of 36. Requires a different paring function.
Refactor of the initialization code (write to device) in order to properly calculate checksum depending on chip address.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with Tasmota core ESP32 V.1.0.7.4
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@arendst
Copy link
Owner

arendst commented Oct 3, 2021

Thx. Will test asap.

I feel a lot of code size optimization using arrays coming along shortly... (change models to 0,1 and 2 and use as index for fixed values).

@arendst arendst merged commit ec412c9 into arendst:development Oct 3, 2021
@arendst
Copy link
Owner

arendst commented Oct 3, 2021

Merged and noticed broken BL0940 support on Blitzwolf SHP10.

Reverted the main file and I will investigate what went wrong here.

@arendst
Copy link
Owner

arendst commented Oct 3, 2021

Ah. I love this message:

BL9: Checksum failurereceived 0x63 instead of 0x63

Will try to solve it now.

arendst added a commit that referenced this pull request Oct 3, 2021
@arendst
Copy link
Owner

arendst commented Oct 3, 2021

Fixed and released

@barbudor
Copy link
Contributor Author

barbudor commented Oct 3, 2021

Thanks @arendst
I missed that

@barbudor barbudor deleted the bl0942_pr branch October 3, 2021 13:28
@ascillato2 ascillato2 added the hacktoberfest-accepted Type - Issue approved for Hacktoberfest Challenge label Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Type - Issue approved for Hacktoberfest Challenge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants